Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use @system to return pointers to stack #4750

Merged
merged 1 commit into from Aug 25, 2016

Conversation

WalterBright
Copy link
Member

Another blocker for dlang/dmd#5972

@dlang-bot
Copy link
Contributor

@WalterBright, thanks for your PR! By analyzing the annotation information on this pull request, we identified @jpf91, @jcd and @MartinNowak to be potential reviewers. @jpf91: The PR was automatically assigned to you, please reassign it if you were identified mistakenly.

(The DLang Bot is under development. If you experience any issues, please open an issue at its repo.)

@codecov-io
Copy link

codecov-io commented Aug 25, 2016

Current coverage is 88.79% (diff: 100%)

Merging #4750 into master will decrease coverage by <.01%

@@             master      #4750   diff @@
==========================================
  Files           121        121          
  Lines         74169      74169          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits          65861      65860     -1   
- Misses         8308       8309     +1   
  Partials          0          0          

Powered by Codecov. Last update aebc8b7...85de788

@dnadlinger
Copy link
Member

Isn't this @system by default?

@andralex
Copy link
Member

annotation is informative nevertheless

@andralex andralex merged commit eb542ed into dlang:master Aug 25, 2016
@WalterBright WalterBright deleted the curl-system branch August 25, 2016 01:38
@dnadlinger
Copy link
Member

@andralex: Nonononono - Walter says this is a blocker, so it apparently isn't just informative with his proposed changes (?).

@andralex
Copy link
Member

@WalterBright?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants