Fix issue 16363 - Cannot construct a random access range using frontTransversal #4754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
@togrue, thanks for your PR! By analyzing the annotation information on this pull request, we identified @andralex, @dsimcha and @monarchdodra to be potential reviewers. @andralex: The PR was automatically assigned to you, please reassign it if you were identified mistakenly. |
| @@ -5752,6 +5752,16 @@ struct FrontTransversal(Ror, | |||
| _input[n].front = val; | |||
| } | |||
| } | |||
| /// Ditto | |||
| static if(hasLength!RangeOfRanges) | |||
|
Approved after nit, thx |
@togrue CircleCI automatically checks for the style. If you rebase your PR onto upstream, these checks will be run too. |
Issue 16363 (Cannot construct a random access range using frontTransversal) https://issues.dlang.org/show_bug.cgi?id=16291 - Added the length property to frontTransversal (only if the length is known)
wilzbach
changed the title
|
Auto-merge toggled on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue 16363 (Cannot construct a random access range using frontTransversal)
https://issues.dlang.org/show_bug.cgi?id=16291