New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix issue 8799 #4882
fix issue 8799 #4882
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@@ -100,6 +100,72 @@ template AliasSeq(TList...) | |||
static assert(is(Types == AliasSeq!(int, double, char))); | |||
} | |||
|
|||
|
|||
/** | |||
Return an AliasSeq expression of $(D Func) being |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/Return/Returns/
s/AliasSeq/AliasSeq
/
s/$(D Func)/Func
/
|
||
template Map(alias Func, args...) | ||
{ | ||
static if (args.length > 1) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
brace on its own line
{ | ||
static if (args.length > 1) { | ||
alias Map = AliasSeq!(ArgCall!(Func, args[0]), Map!(Func, args[1 .. $])); | ||
} else { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
brace on its own line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to change the commit message from "Issue_8799" to "fix issue 8799", otherwise the dlang bot cannot track the issue.
@bbasile Thanks for pointing that out! Is it ok now? |
You still haven't triggered the bot. You have to amend or rebase. With git gui it's easy. The problem is not on GitHub, the problem is with the the git stuffs.
And after you force the push, you're on a branch so the rebase doesnt matter. |
|
thx! |
Please review! Let me know if this example is appropriate.
Link: https://issues.dlang.org/show_bug.cgi?id=8799
Thank you!