Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue 8799 #4882

Merged
merged 2 commits into from Nov 1, 2016
Merged

fix issue 8799 #4882

merged 2 commits into from Nov 1, 2016

Conversation

somzzz
Copy link
Contributor

@somzzz somzzz commented Oct 29, 2016

Please review! Let me know if this example is appropriate.
Link: https://issues.dlang.org/show_bug.cgi?id=8799

Thank you!

Copy link
Member

@andralex andralex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@@ -100,6 +100,72 @@ template AliasSeq(TList...)
static assert(is(Types == AliasSeq!(int, double, char)));
}


/**
Return an AliasSeq expression of $(D Func) being
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/Return/Returns/
s/AliasSeq/AliasSeq/
s/$(D Func)/Func/


template Map(alias Func, args...)
{
static if (args.length > 1) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

brace on its own line

{
static if (args.length > 1) {
alias Map = AliasSeq!(ArgCall!(Func, args[0]), Map!(Func, args[1 .. $]));
} else {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

brace on its own line

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to change the commit message from "Issue_8799" to "fix issue 8799", otherwise the dlang bot cannot track the issue.

@somzzz somzzz changed the title Issue_8799 fix issue 8799 Oct 31, 2016
@somzzz
Copy link
Contributor Author

somzzz commented Oct 31, 2016

@bbasile Thanks for pointing that out! Is it ok now?

@ghost
Copy link

ghost commented Nov 1, 2016

You still haven't triggered the bot. You have to amend or rebase. With git gui it's easy. The problem is not on GitHub, the problem is with the the git stuffs.

git rebase -i origin/master

  • add "fix issue 8799" to the first commit message.
  • change the command of the second commit to "fixup".
  • save ( ESC:wqENTER)

And after you force the push, you're on a branch so the rebase doesnt matter.

@dlang-bot
Copy link
Contributor

Fix Bugzilla Description
8799 Give example of Tuple mapped to a function

@andralex andralex merged commit c77869f into dlang:master Nov 1, 2016
@andralex
Copy link
Member

andralex commented Nov 1, 2016

thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants