Make more modules publicly runnable on dlang.org #4966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilzbach
commented
Dec 19, 2016
| @@ -3934,7 +3934,6 @@ private T octal(T)(const string num) | |||
| return value; | |||
| } | |||
|
|
|||
| /// | |||
| @system unittest | |||
There was a problem hiding this comment.
This is a private method - there's no point in exposing in trying to expose the unittest
| * Returns: the maximum value | ||
| */ | ||
| T max (T) (T[] arr) | ||
| { |
There was a problem hiding this comment.
this was superseded by maxElement
| @@ -1953,7 +1922,6 @@ ElementType!(A) pop (A) (ref A a) if (isDynamicArray!(A) && !isNarrowString!(A) | |||
| return e; | |||
| } | |||
|
|
|||
| /// | |||
| unittest | |||
| { | |||
| auto array = [0, 1, 2, 3]; | |||
There was a problem hiding this comment.
Seems like there is already shift within Phobos ;-)
(though this one is private)
| @@ -1846,7 +1818,6 @@ T[] substr (T) (T[] str, ptrdiff_t start = 0, ptrdiff_t length = ptrdiff_t.min) | |||
| return str[start .. end]; | |||
| } | |||
|
|
|||
| /// | |||
| unittest | |||
| { | |||
| @@ -1898,7 +1869,6 @@ int compareFirstN (alias pred = "a < b", S1, S2) (S1 s1, S2 s2, size_t length, b | |||
| return caseInsensitive ? slice1.icmp(slice2) : slice1.cmp(slice2); | |||
| } | |||
|
|
|||
| /// | |||
| unittest | |||
| { | |||
| @@ -1929,7 +1899,6 @@ auto grep (Range, Regex) (Range input, Regex pattern, bool invert = false) | |||
| return filter!(dg)(input); | |||
| } | |||
|
|
|||
| /// | |||
| unittest | |||
wilzbach
force-pushed
the
public-editable-modules
branch
2 times, most recently
from
602b23e
to
ff1f2d2
Compare
|
So if someone is interested in the motivation/rationale, please have a look at e.g. https://dlang.org/phobos-prerelease/std_algorithm_searching.html#.minElement |
MartinNowak
force-pushed
the
public-editable-modules
branch
from
ff1f2d2
to
18ecb6b
Compare
|
rebased |
MartinNowak
approved these changes
Jan 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #4943: this PR reduces the module exclusion for modules that can be run on dlang.org
For this all tests within a module need to pass separately without the module.