fix issue 16634 - std.math exposes yl2x and yl2xp1 publicly

[somzzz]

There was duplicate code in core.math and std.math: the same function declarations and the same unittests. yl2x and yl2xp1 are implemented in the compiler.

There is indeed no proper documentation for their existence in phobos. I could not find documentation for core.math.yl2xp1 either. Maybe it should be added as part of this PR?

So far, I removed these functions from phobos, since they are available in core.math and std offers no extra functionality with regard to them. Please let me know if there is a valid reason for keeping them in both druntime and phobos. If that is the case, we can simply document the situation.

[dlang-bot]

Fix	Bugzilla	Description
✓	16634	std.math exposes yl2x and yl2xp1 publicly

[wilzbach]

So far, I removed these functions from phobos, since they are available in core.math and std offers no extra functionality with regard to them. Please let me know if there is a valid reason for keeping them in both druntime and phobos. If that is the case, we can simply document the situation.

Git log says that core.math was created by @braddr and yl2x / yl2xp1 in Phobos come from @WalterBright.
What's the history here?

There is indeed no proper documentation for their existence in phobos. I could not find documentation for core.math.yl2xp1 either.

There is only a mere one-line :/

https://dlang.org/phobos/core_math.html#.yl2x

[andralex]

@WalterBright @9il @ibuclaw could you please take a look at this?

[9il]

No math changes, the only question is proper intrinsics location. Please wait review from DRuntime/Compiler team members.

[UplinkCoder]

The intrinsic is core.math.{yl2x, yl2xp1}.
phobos functions may not be intrinsics.
The PR looks fine to me.

[andralex]

Thanks everyone!

[andralex]

Auto-merge toggled on

[WalterWaldron]

Shouldn't this have gone through a deprecation cycle?