Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix std.range.Zip.save #4976

Merged
merged 1 commit into from Dec 21, 2016
Merged

Fix std.range.Zip.save #4976

merged 1 commit into from Dec 21, 2016
+14 −1

Conversation

ErinaceusEuropaeus
Copy link
Contributor

It's funny how the pseudo-code is actually correct.

@quickfur
Copy link
Member

Is there a bugzilla issue filed for this problem?

quickfur
quickfur reviewed Dec 20, 2016
View reviewed changes
Copy link
Member

@quickfur quickfur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes themselves look good to me. Good catch of something that has been missed this long!

@ErinaceusEuropaeus
Copy link
Contributor Author

This problem doesn't show up when searching the bugzilla for zip related issues and I haven't filed anything myself (seemed unnecessary).

quickfur
quickfur approved these changes Dec 20, 2016
View reviewed changes
Copy link
Member

@quickfur quickfur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough. This change is simple enough to approve.

@JackStouffer
Copy link
Member

Auto-merge toggled on

@JackStouffer JackStouffer merged commit ab84f30 into dlang:master Dec 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quickfur quickfur quickfur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@ErinaceusEuropaeus @quickfur @JackStouffer