fix issue 17139 - dscanner needs to handle 'scope' function attributes #5085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
JackStouffer
previously approved these changes
Feb 3, 2017
|
I would disable the |
|
This is another thing that's not handled by libdparse. I see exactly what's the problem but it's not fixable quickly, it requires @Hackerpilot intervention. This is like dlang-community/libdparse#106. There's 3rd rule that's still not handled. |
JackStouffer
reviewed
Feb 3, 2017
std/json.d
Outdated
| @@ -37,7 +37,7 @@ import std.traits; | |||
|
|
|||
| // check a type | |||
| long x; | |||
| if (const(JSONValue)* code = "code" in j) | |||
| if (auto code = "code" in j) | |||
There was a problem hiding this comment.
Can you use const here instead of auto?
There was a problem hiding this comment.
const identifier now works but it breaks const(Type). because it predates the typectors which are also used for the rule I broke. I'm gonna make a libdparse PR.
|
@JackStouffer, sorry for the mishaps but this is good now. |
Hackerpilot
approved these changes
Feb 4, 2017
JackStouffer
approved these changes
Feb 4, 2017
|
Auto-merge toggled on |
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.