New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidated and added examples to the std.format.unformatValue docs #5130
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of nits again. Otherwise LGTM (though it was a bit difficult to match the moved unittest blocks)
std/format.d
Outdated
assert(!f1); | ||
} | ||
|
||
pure unittest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
std/format.d
Outdated
* Returns: | ||
* A value from `input` of type `T` | ||
* Throws: | ||
* An `Exception` if `spec` does cannot read a type `T` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove: "does"
std/format.d
Outdated
} | ||
|
||
pure unittest | ||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
2425809
to
d78301a
Compare
@wilzbach fixed |
Auto-merge toggled on |
Looking forward to the next iteration ;-) |
Ok, so the diff is so large, because for some reason, there were a bunch of unrelated unit tests strewn about the functions here. In order for the docs to be properly formatted, they had to be moved.
Otherwise, this takes some horrible docs and makes them understandable.