Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidated and added examples to the std.format.unformatValue docs #5130

Merged
merged 1 commit into from Feb 15, 2017

Conversation

JackStouffer
Copy link
Member

@JackStouffer JackStouffer commented Feb 14, 2017

Ok, so the diff is so large, because for some reason, there were a bunch of unrelated unit tests strewn about the functions here. In order for the docs to be properly formatted, they had to be moved.

Otherwise, this takes some horrible docs and makes them understandable.

Copy link
Member

@wilzbach wilzbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of nits again. Otherwise LGTM (though it was a bit difficult to match the moved unittest blocks)

std/format.d Outdated
assert(!f1);
}

pure unittest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add either @System or @safe

std/format.d Outdated
* Returns:
* A value from `input` of type `T`
* Throws:
* An `Exception` if `spec` does cannot read a type `T`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove: "does"

std/format.d Outdated
}

pure unittest
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

@JackStouffer
Copy link
Member Author

@wilzbach fixed

@wilzbach
Copy link
Member

Auto-merge toggled on

@wilzbach
Copy link
Member

wilzbach commented Feb 15, 2017

Otherwise, this takes some horrible docs and makes them understandable.

Looking forward to the next iteration ;-)

@wilzbach wilzbach merged commit eb2bf6f into dlang:master Feb 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants