Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue 17340 - isNumeric!bool should not be true #5343

Merged
merged 1 commit into from Apr 27, 2017
Merged

Fix issue 17340 - isNumeric!bool should not be true #5343

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 3 additions & 2 deletions std/traits.d
View file
Open in desktop
Expand Up @@ -5612,15 +5612,15 @@ enum bool isFloatingPoint(T) = __traits(isFloating, T) && !(is(Unqual!T == cfloa
* Detect whether $(D T) is a built-in numeric type (integral or floating
* point).
*/
enum bool isNumeric(T) = __traits(isArithmetic, T) && !(is(Unqual!T == char) ||
enum bool isNumeric(T) = __traits(isArithmetic, T) && !(is(Unqual!T == bool) ||
is(Unqual!T == char) ||
is(Unqual!T == wchar) ||
is(Unqual!T == dchar));

///
@safe unittest
{
static assert(
isNumeric!bool &&
isNumeric!byte &&
isNumeric!short &&
isNumeric!int &&
Expand All @@ -5634,6 +5634,7 @@ enum bool isNumeric(T) = __traits(isArithmetic, T) && !(is(Unqual!T == char) ||

static assert(
!isNumeric!void &&
!isNumeric!bool &&
!isNumeric!char &&
!isNumeric!wchar &&
!isNumeric!dchar
Expand Down