fix Issue 15517: std.experimental.logger: using 'sharedLog' to change to file logging for default logger does not work #5371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
JackStouffer
reviewed
May 7, 2017
std/experimental/logger/core.d
Outdated
| @@ -3102,3 +3102,39 @@ private void trustedStore(T)(ref shared T dst, ref T src) @trusted | |||
| tl.logf("%s", sts); | |||
| assert(tl.msg == SystemToStringMsg); | |||
| } | |||
|
|
|||
| // Issue 15517 | |||
| unittest | |||
There was a problem hiding this comment.
Please mark this as either system or safe.
There was a problem hiding this comment.
See also CircleCi or style:
Running DScanner
../dscanner/dsc --config .dscanner.ini --styleCheck $(find etc std -type f -name '*.d' | grep -vE 'std/traits.d|std/typecons.d') -I.
std/experimental/logger/core.d(3107:1)[warn]: A unittest should be annotated with at least @safe or @system
make: *** [style] Error 1
|
Please improve the commit message. |
std/experimental/logger/core.d
Outdated
|
|
||
| foreach (t; ts) | ||
| { | ||
| sharedLog.log(t); |
There was a problem hiding this comment.
Wait, isn't this exactly what the bug report was talking about? This works, but just doing
log(t);
doesn't
There was a problem hiding this comment.
@burner This has now reverted
wilzbach
changed the title
JackStouffer
approved these changes
May 26, 2017
|
@burner Please rebase |
|
@JackStouffer rebased |
JackStouffer
requested changes
May 26, 2017
std/experimental/logger/core.d
Outdated
|
|
||
| foreach (t; ts) | ||
| { | ||
| sharedLog.log(t); |
There was a problem hiding this comment.
@burner This has now reverted
|
fixed |
JackStouffer
approved these changes
May 26, 2017
was already fixed but had no fixture
|
@JackStouffer win32 works finally, I didn't allow me to open a file twice. |
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
was already fixed but had no fixture