New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make std.file.deleteme package. #5400
Conversation
Agree, looking below, you can stick this function, the next struct and the |
There is no reason to expose a function that's purely for unit testing Phobos.
Okay. I updated it as suggested and put all 3 of those sections in the same |
Careful, If it's useful enough for examples, it might be useful for real code as well. Can it be promoted to a "real" public function instead? |
Hmmm. This definitely seems like a downside to insisting on the examples being runnable as-is by anyone rather than just be understandable and informative. The fact that |
Is there some way it can be removed from the runnable examples? I always felt it distracted from them, by adding file management baggage. @wilzbach, what do you think? |
I'd vote for actually making it more public, and making the functionality more robust. |
Pinging @wilzbach again, regardless of whether btw, I just tried the same runnable example that was crashing for me before and wasn't able to reproduce anymore. :) |
Hmm from what I understand, there are at least these three options to go:
I honestly have to admit that I would prefer having something like
Hmm imho with a proper name, there wouldn't be any need for a noob to figure out what it means.
Great :) |
I agree that simply renaming @jmdavis, can you amend this PR to make |
@jmdavis do you still intend to continue with this? If not can you please close it? |
There is no reason to expose a function that's purely for unit testing
Phobos.