Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue 17479: public ctors for std.process.Pid #5450

Closed
wants to merge 1 commit into from
Closed

Fix issue 17479: public ctors for std.process.Pid #5450

wants to merge 1 commit into from

Conversation

dhasenan
Copy link
Contributor

@dhasenan dhasenan commented Jun 8, 2017

While the ctors are platform-specific, this isn't adding a significant amount of platform incompatibility -- Pid already exposes the process handle, which is only valid on Windows.

@dlang-bot
Copy link
Contributor

Fix Bugzilla Description
✓ 17479 Public constructor for std.process.Pid

CyberShadow
CyberShadow requested changes Jun 8, 2017
View reviewed changes
Copy link
Member

@CyberShadow CyberShadow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(see bugzilla)

@CyberShadow
Copy link
Member

CyberShadow commented Jun 8, 2017 •
edited

Duplicate of #5086 ?

@edi33416
Copy link
Contributor

edi33416 commented Jun 8, 2017

Duplicate of 5086 ?

I think so.

@edi33416
Copy link
Contributor

edi33416 commented Jun 8, 2017

@dhasenan have a look at #5086

@dhasenan dhasenan closed this Jun 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CyberShadow CyberShadow CyberShadow requested changes

Assignees
No one assigned
Labels
Bug Fix
Projects
None yet
Milestone
No milestone
4 participants
@dhasenan @dlang-bot @CyberShadow @edi33416