New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-add has_public_example to circleci.sh for legacy compatibility #5514
Conversation
Sounds good to me. What about stable? |
|
Hmm, then why is #5511 failing? |
Arrgh Jenkins failing again. Could we give fixes like dlang/ci#47 more priority (even if they don't solve the root cause)? |
b914942
to
aa83f56
Compare
Thanks for your pull request, @wilzbach! We are looking forward to reviewing it, and you should be hearing from a maintainer soon. Some tips to help speed things up:
Bear in mind that large or tricky changes may require multiple rounds of review and revision. Please see CONTRIBUTING.md for more information. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
(rebased as this is the only way I know to rekick Jenkins ...) |
Urrgh now dlang/dmd#6940 has propagated the version PR into master and CircleCI is now failing for master as well:
|
aa83f56
to
5cc58f9
Compare
(yet another rebase to kick Jenkins) |
5cc58f9
to
5d1bd05
Compare
and yet another rebase for Jenkins ... |
This should fix the CircleCi build failures on older PRs and avoids the unnecessary need to rebase.
Background: we merge the PR branch into the target branch, hence the newest
circleci.sh
is always applied, but unfortunately we thecircle.yml
isn't updated. While we could use just one target e.g.test
, using multiple has the advantage of visually grouping them nicely and thus helping a reader to track down the root of the failure.CC @CyberShadow @schveiguy @JackStouffer @ZombineDev