Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

formattedWrite should take output range by reference #5648

Merged
merged 3 commits into from Jul 23, 2017
Merged

formattedWrite should take output range by reference #5648

merged 3 commits into from Jul 23, 2017

Conversation

japplegame
Copy link
Contributor

At the moment formattedWrite takes output range by value. It prevents to pass non-copyable ranges.

At the moment formattedWrite takes output range by value. It prevents to pass non-copyable ranges.
@dlang-bot
Copy link
Contributor

Thanks for your pull request, @japplegame! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.

Some tips to help speed things up:

  • smaller, focused PRs are easier to review than big ones

  • try not to mix up refactoring or style changes with bug fixes or feature enhancements

  • provide helpful commit messages explaining the rationale behind each change

Bear in mind that large or tricky changes may require multiple rounds of review and revision.

Please see CONTRIBUTING.md for more information.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

@dlang-bot dlang-bot merged commit e8ef731 into dlang:master Jul 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants