Fix Issue 6580 - scoped classes are aligned incorrectly #570
Conversation
| @@ -3087,9 +3087,27 @@ unittest | |||
| return result; | |||
| } | |||
|
|
|||
| private template maxAlignmentType(U...) if(isTypeTuple!U) { | |||
There was a problem hiding this comment.
Place braces on their own lines.
|
Auto tester shows an error in Windows platform. |
Changed.
So I have missed something. Interesting... |
|
Damn! It passes now, it's very bad... I'll play with autotester a bit because I can't reproduce the failure on my Win32 PC. |
|
OK. 38e55e021f65b02ed431fef2e029152fc8a56061 fails at line 3174 (test results). So here is the question: should And what to do with |
|
Done. |
| } | ||
| alias Scoped_payload this; | ||
| alias m_payload this; |
There was a problem hiding this comment.
Don't remove Scoped_ prefixes. They need to avoid conflicts with T's members.
There was a problem hiding this comment.
Fixed. Sorry.
Looks like for current dmd even private store has to be Scoped_store...
|
OK. In general, class objects are allocated in gc heap and aligned correctly. |
Fix Issue 6580 - scoped classes are aligned incorrectly
Not sure if
forAlignmentOnlywill work on every compiler but can't invent anything better.