Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation for std.path.dirName #6075

Merged
merged 1 commit into from Jan 27, 2018
Merged

Conversation

bachmeil
Copy link
Contributor

The documentation currently says "Returns the directory part of a path." That is incorrect, because it actually returns the parent directory no matter what the argument path is (even if path is a directory).

https://issues.dlang.org/show_bug.cgi?id=18294

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @bachmeil! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.

Some tips to help speed things up:

  • smaller, focused PRs are easier to review than big ones

  • try not to mix up refactoring or style changes with bug fixes or feature enhancements

  • provide helpful commit messages explaining the rationale behind each change

Bear in mind that large or tricky changes may require multiple rounds of review and revision.

Please see CONTRIBUTING.md for more information.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

@quickfur quickfur added documentation Trivial typos, formatting, comments Easy Review labels Jan 26, 2018
Copy link
Member

@quickfur quickfur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wilzbach wilzbach merged commit 7e8c159 into dlang:master Jan 27, 2018
@bachmeil bachmeil deleted the patch-1 branch January 28, 2018 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Easy Review Trivial typos, formatting, comments
Projects
None yet
4 participants