Fix Issue 8341 - topN(zip()) doesn't work #6156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilzbach
requested review from
andralex,
JackStouffer and
PetarKirov
as code owners
wilzbach
force-pushed
the
fix-8341
branch
3 times, most recently
from
0bb776a
to
8e7ea82
Compare
JackStouffer
reviewed
Mar 2, 2018
| @@ -3100,7 +3102,8 @@ Stable topN has not been implemented yet. | |||
| auto topN(alias less = "a < b", | |||
| SwapStrategy ss = SwapStrategy.unstable, | |||
| Range)(Range r, size_t nth) | |||
| if (isRandomAccessRange!(Range) && hasLength!Range && hasSlicing!Range) | |||
| if (isRandomAccessRange!(Range) && hasLength!Range && | |||
| hasSlicing!Range && hasAssignableElements!Range) | |||
There was a problem hiding this comment.
Shouldn't this be hasSwappableElements?
There was a problem hiding this comment.
No it calls pivotPartition which calls moveAt and assigns to the element:
auto save = r.moveAt(hi);
...
r[lo] = save;hasSwappableElements just requires that swap(a, b) works.
JackStouffer
approved these changes
Mar 12, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
topNrequires an assignable range. While fixing the constraint oftopN, I found that almost the entire module had missing constraints.This should improve the error messages slightly, i.e. now they aren't in
std.algorithmanymore, but the user at least gets "no matching function found" and sees the constraints.