Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix conversion from wchar to char in LockingTextWriter.put #6474

Merged
merged 6 commits into from
Apr 29, 2018
Merged

fix conversion from wchar to char in LockingTextWriter.put #6474

merged 6 commits into from
Apr 29, 2018

Commits on Apr 23, 2018

  1. fix conversion from wchar to char in LockingTextWriter.put 

    Fixes the easier part of issue 18789.
    @aG0aep6G
    aG0aep6G committed Apr 23, 2018
    Configuration menu
    Copy the full SHA
    d5cc4c5 View commit details
    Browse the repository at this point in the history

  2. destroy file_ before possibly throwing

    @aG0aep6G
    aG0aep6G committed Apr 23, 2018
    Configuration menu
    Copy the full SHA
    8611e45 View commit details
    Browse the repository at this point in the history

  3. add comment about the final throw

    @aG0aep6G
    aG0aep6G committed Apr 23, 2018
    Configuration menu
    Copy the full SHA
    2ab81bc View commit details
    Browse the repository at this point in the history

  4. only store the high surrogate, and use \0 to indicate its empty

    @aG0aep6G
    aG0aep6G committed Apr 23, 2018
    Configuration menu
    Copy the full SHA
    bf1b4db View commit details
    Browse the repository at this point in the history

  5. merge imports

    @aG0aep6G
    aG0aep6G committed Apr 23, 2018
    Configuration menu
    Copy the full SHA
    5fa8ba1 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2018

  1. only decode when there's a highSurrogate

    @aG0aep6G
    aG0aep6G committed Apr 24, 2018
    Configuration menu
    Copy the full SHA
    b771e17 View commit details
    Browse the repository at this point in the history