Fix Issue 18952 - std.experimental.checkedint.Saturate prints integral promotion deprecation message #6549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request, @wilzbach! Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + phobos#6549" |
carun
reviewed
Jun 6, 2018
std/experimental/checkedint.d
Outdated
| assert(x.isNaN); | ||
| } | ||
|
|
||
| // ProperCompare fixes the comparison operators ==, !=, <, <=, >, and >= to return correct results |
There was a problem hiding this comment.
Probably doc comment with ///
carun
reviewed
Jun 6, 2018
std/experimental/checkedint.d
Outdated
| assert(y > -1); // ProperCompare | ||
| } | ||
|
|
||
| // Throws fails every incorrect operation by throwing an exception |
There was a problem hiding this comment.
Probably doc comment with ///
ghost
suggested changes
Jun 8, 2018
std/experimental/checkedint.d
Outdated
| assert(y > -1); // ProperCompare | ||
| } | ||
|
|
||
| /// Throws fails every incorrect operation by throwing an exception |
…l promotion deprecation message
|
Good idea to use backticks. Thanks! |
ghost
approved these changes
Jun 8, 2018
n8sh
approved these changes
Jun 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added a few public documentation examples as unittests.
I added them in the top as there was only one high-level example.