std.regex fix .* optimization issues (issue 6072) #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks very much! |
andralex
added a commit
that referenced
this pull request
May 31, 2011
std.regex fix .* optimization issues (issue 6072)
kuettler
pushed a commit
to kuettler/phobos
that referenced
this pull request
Feb 6, 2018
fix Issue 10352 - Regression (2.063): --eval is broken in RDMD
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds fixed isuess to changelog and reduces alloca burden to 32 Kb (if available).
Now there is one problem with it I can't figure, on all of 32 bits it passes all tests.
On 64 bit when I run make MODEL=64 -fposix.mak unittest
I get the following from linker:
generated/linux/debug/64/unittest/std/regex.o: In function
_D3std5regex20__T10RegexMatchTAyuZ10RegexMatch8trymatchMFkAhZb': /home/dmitry/dmd2/src/phobos/std/regex.d:2352: undefined reference to_D3std3utf10strideBackFNaNfxAumZk'generated/linux/debug/64/unittest/std/regex.o: In function
_D3std5regex20__T10RegexMatchTAyaZ10RegexMatch8trymatchMFkAhZb': /home/dmitry/dmd2/src/phobos/std/regex.d:2352: undefined reference to_D3std3utf10strideBackFNaNfxAamZk'generated/linux/debug/64/unittest/std/regex.o: In function
_D3std5regex20__T10RegexMatchTAywZ10RegexMatch8trymatchMFkAhZb': /home/dmitry/dmd2/src/phobos/std/regex.d:2352: undefined reference to_D3std3utf10strideBackFNaNbNfxAwmZk'generated/linux/debug/64/unittest/std/regex.o: In function
_D3std5regex19__T10RegexMatchTAaZ10RegexMatch8trymatchMFkAhZb': /home/dmitry/dmd2/src/phobos/std/regex.d:2352: undefined reference to_D3std3utf10strideBackFNaNfxAamZk'Any ideas?