Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 19162 - [REG: 2.079.0] Public Import Overlapping Names Conflict Resolution #6664

Merged
merged 4 commits into from Aug 21, 2018
Merged

Conversation

ghost
Copy link

@ghost ghost commented Aug 15, 2018

This shouldn't have been committed to begin with until after the actual issue had been fixed. A breaking change which allows abs() to be instigated for all types irregardless if they have comparison and negative operators.

@wilzbach Per your commit.

@ghost ghost requested review from ibuclaw and dnadlinger as code owners August 15, 2018 03:22
@dlang-bot
Copy link
Contributor

dlang-bot commented Aug 15, 2018

Thanks for your pull request and interest in making D better, @look-at-me! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
18051 enhancement missing enum support in formattedRead/unformatValue
19162 regression [REG: 2.079.0] Public Import Overlapping Names Conflict Resolution

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "stable + phobos#6664"

Copy link
Member

@wilzbach wilzbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Urgh. I don't why this found its way into mainline. Sorry!
For a speedy merge, I added a test based on your issue and also fixed the order of the constraints to avoid the integral promotion message (maybe that was the initial motivation?)

@wilzbach
Copy link
Member

Argh it looks like https://issues.dlang.org/show_bug.cgi?id=18250 and https://issues.dlang.org/show_bug.cgi?id=18251 are still in effect:

std/math.d(629): Deprecation: use of imaginary type `ireal` is deprecated, use `real` instead
std/math.d(629): Deprecation: use of imaginary type `ireal` is deprecated, use `real` instead
std/math.d(629): Deprecation: use of imaginary type `ireal` is deprecated, use `real` instead
std/math.d(629): Deprecation: use of imaginary type `ireal` is deprecated, use `real` instead

@wilzbach
Copy link
Member

I pushed another commit with the TestComplex workaround (the same was used for e.g. std.format) - a972e26#diff-e28dc7a93ec122fed96f51899af668a0R2608

@wilzbach wilzbach changed the title Fix issue 19162 Fix issue 19162 - [REG: 2.079.0] Public Import Overlapping Names Conflict Resolution Aug 15, 2018
@wilzbach wilzbach added this to the 2.082 milestone Aug 15, 2018
@wilzbach wilzbach changed the base branch from master to stable August 20, 2018 12:09
@wilzbach
Copy link
Member

Rebased this onto stable, s.t. we still can get it in for 2.082.
@ others: what do you think about the version(TestComplex) workaround?
It does fix this issue and we have done it for std.format too as it looks like it's the only solution for the complex type deprecation we have at the moment :/

Copy link
Member

@PetarKirov PetarKirov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for working on this issue @look-at-me and @wilzbach!

@dlang-bot dlang-bot merged commit dc2c899 into dlang:stable Aug 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants