New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue 19162 - [REG: 2.079.0] Public Import Overlapping Names Conflict Resolution #6664
Conversation
Thanks for your pull request and interest in making D better, @look-at-me! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "stable + phobos#6664" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Urgh. I don't why this found its way into mainline. Sorry!
For a speedy merge, I added a test based on your issue and also fixed the order of the constraints to avoid the integral promotion message (maybe that was the initial motivation?)
Argh it looks like https://issues.dlang.org/show_bug.cgi?id=18250 and https://issues.dlang.org/show_bug.cgi?id=18251 are still in effect:
|
I pushed another commit with the |
Rebased this onto stable, s.t. we still can get it in for 2.082. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for working on this issue @look-at-me and @wilzbach!
This shouldn't have been committed to begin with until after the actual issue had been fixed. A breaking change which allows abs() to be instigated for all types irregardless if they have comparison and negative operators.
@wilzbach Per your commit.