Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AArch64] [GDC] Fix two small AArch64 bugs / typos #6719

Merged
merged 2 commits into from
Sep 30, 2018

Conversation

jpf91
Copy link
Contributor

@jpf91 jpf91 commented Sep 23, 2018

Mostly trivial stuff.
Link: D-Programming-GDC/gdc#744

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @jpf91! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + phobos#6719"

std/complex.d Outdated Show resolved Hide resolved
The implementations are not equal and may lead slightly different
results (e.g. on AArch64 with GDC)
@dlang-bot dlang-bot merged commit a00b2e5 into dlang:master Sep 30, 2018
jpf91 added a commit to jpf91/GDC that referenced this pull request Oct 28, 2018
dlang/phobos#6719
00301f0f0b2d5ca7c5c3bf77a9902285d1c2f091
jpf91 added a commit to jpf91/GDC that referenced this pull request Oct 28, 2018
jpf91 added a commit to jpf91/GDC that referenced this pull request Oct 29, 2018
dlang/phobos#6719
00301f0f0b2d5ca7c5c3bf77a9902285d1c2f091
jpf91 added a commit to jpf91/GDC that referenced this pull request Oct 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants