-
-
Notifications
You must be signed in to change notification settings - Fork 694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AArch64] [GDC] Fix two small AArch64 bugs / typos #6719
Conversation
Thanks for your pull request and interest in making D better, @jpf91! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + phobos#6719" |
387b2be
to
605ed8b
Compare
The implementations are not equal and may lead slightly different results (e.g. on AArch64 with GDC)
dlang/phobos#6719 00301f0f0b2d5ca7c5c3bf77a9902285d1c2f091
dlang/phobos#6719 5870efca77b57d79043b3520862cbff732d433ef
dlang/phobos#6719 00301f0f0b2d5ca7c5c3bf77a9902285d1c2f091
dlang/phobos#6719 5870efca77b57d79043b3520862cbff732d433ef
Mostly trivial stuff.
Link: D-Programming-GDC/gdc#744