Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix opBinary[Right]CustomFloat op CustomFloat ambiguity #6754

Closed
wants to merge 1 commit into from

Conversation

thewilsonator
Copy link
Contributor

@dlang-bot
Copy link
Contributor

dlang-bot commented Nov 6, 2018

Thanks for your pull request and interest in making D better, @thewilsonator! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + phobos#6754"

@thewilsonator
Copy link
Contributor Author

cc @RazvanN7 - please review carefully.

@thewilsonator thewilsonator changed the base branch from master to stable November 7, 2018 02:30
@thewilsonator thewilsonator changed the base branch from stable to master November 7, 2018 02:31
@thewilsonator
Copy link
Contributor Author

Bleeagh, this needs to be targeted to stable for dlang/dmd#8922, but that adds a bunch of other commits, which I think are on master.

@wilzbach
Copy link
Member

Rebasing with the CLI to stable isn't too hard, is it?
Just git rebase --onto upstream/stable upstream/master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants