Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move std.experimental.all to std #6889

Merged
merged 1 commit into from Mar 21, 2019
Merged

Move std.experimental.all to std #6889

merged 1 commit into from Mar 21, 2019

Conversation

wilzbach
Copy link
Member

@wilzbach wilzbach commented Mar 4, 2019

std.experimental.all has been added more than a year ago (see #5916).

When we added it, we agreed to use experimental first to see whether there are any flaws with such a convenience package.
As none of these have been discovered and on the contrary more work has been started (and merged in some cases) which makes the compiler (or at least Phobos) compile faster.

Also, as the D community started to like this package, I think this was successful experiment and we should stabilize it.

BTW any interested reader can find a lot of examples of std.experimental.all in action in D forums posts.
A short excerpt:

Also, once this is stabilized, I can finally enable it by default for run.dlang.io.

@wilzbach wilzbach requested a review from andralex as a code owner March 4, 2019 05:41
@dlang-bot
Copy link
Contributor

Thanks for your pull request, @wilzbach!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + phobos#6889"

@thewilsonator
Copy link
Contributor

Huh?

Error: linker exited with status 1
Makefile:209: recipe for target 'generated/sanitize_json' failed
make[1]: *** [generated/sanitize_json] Error 1
make[1]: *** Waiting for unfinished jobs....
../../phobos/generated/linux/release/32/libphobos2.so: undefined reference to `_D3std12__ModuleInfoZ'

changelog/std-all.dd Outdated Show resolved Hide resolved
win32.mak Show resolved Hide resolved
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, let's get the merge

Copy link
Member

@PetarKirov PetarKirov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this, I'm strongly in favor!
It needs a little bit of work on the ddoc side, but I think this can only be done in the dlang/dlang.org repo after this PR is merged. (E.g. we need to link the std/package.d docs from more places.)

std/package.d Outdated Show resolved Hide resolved
std/package.d Outdated Show resolved Hide resolved
std/package.d Outdated Show resolved Hide resolved
std/package.d Outdated Show resolved Hide resolved
@PetarKirov
Copy link
Member

Hey @wilzbach, you up for finishing this PR?

@PetarKirov
Copy link
Member

@andralex do we have a go or no go from your side?

@PetarKirov PetarKirov added the @andralex Approval from Andrei is required label Mar 17, 2019
Copy link
Member

@andralex andralex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of changes requested. Let's do this, thanks for the work.

changelog/std-all.dd Outdated Show resolved Hide resolved
changelog/std-all.dd Outdated Show resolved Hide resolved
changelog/std-all.dd Outdated Show resolved Hide resolved
std/package.d Outdated Show resolved Hide resolved
@andralex andralex removed the @andralex Approval from Andrei is required label Mar 18, 2019
@wilzbach
Copy link
Member Author

OK. I went through the comments and also added a proper deprecation message for std.experimental.all.

-> this should be good to go now (:

CC @thewilsonator

@thewilsonator
Copy link
Contributor

Automerge added.

@wilzbach
Copy link
Member Author

Force merging as Walter's recent -dip1000 push broke CircleCi.

@wilzbach wilzbach merged commit 75a2faf into dlang:master Mar 21, 2019
@wilzbach wilzbach deleted the all branch March 21, 2019 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants