New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge remote-tracking branch 'upstream/stable' into merge_stable #6943
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of a series on issue 18657.
Part of a series on issue 18657.
Part of a series on issue 18657.
make `group`, `chain`, and `choose` compatible with `RefRange` merged-on-behalf-of: Nicholas Wilson <thewilsonator@users.noreply.github.com>
Part of a series on issue 18657.
Part of a series on issue 18657.
Part of a series on issue 18657.
Part of a series on issue 18657.
…ave` like it should
fix issue 19765 - std.algorithm.searching.findAmong doesn't `save` li…
make `cycle`, `splitter`, `roundRobin`, and `until` compatible with `RefRange`
Prevents compilation of unittests into user modules fix Issue 18818 - unittests are compiled into user modules
variant.d: Gated unittests behind version(StdDdoc)
use constructors instead of `move`
MartinNowak
requested review from
andralex,
JackStouffer,
wilzbach and
PetarKirov
as code owners
April 6, 2019 01:49
Thanks for your pull request, @MartinNowak! Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + phobos#6943" |
Looks like the RefRange changes make
|
I've looked into this. PR: #6950 |
Closing in favor of #6951 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.