Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge remote-tracking branch 'upstream/stable' into merge_stable #6943

Closed
wants to merge 17 commits into from

Conversation

MartinNowak
Copy link
Member

No description provided.

aG0aep6G and others added 17 commits March 24, 2019 15:19
Part of a series on issue 18657.
Part of a series on issue 18657.
Part of a series on issue 18657.
make `group`, `chain`, and `choose` compatible with `RefRange`
merged-on-behalf-of: Nicholas Wilson <thewilsonator@users.noreply.github.com>
Part of a series on issue 18657.
Part of a series on issue 18657.
Part of a series on issue 18657.
Part of a series on issue 18657.
fix issue 19765 - std.algorithm.searching.findAmong doesn't `save` li…
make `cycle`, `splitter`, `roundRobin`, and `until` compatible with `RefRange`
Prevents compilation of unittests into user modules
fix Issue 18818 - unittests are compiled into user modules
variant.d: Gated unittests behind version(StdDdoc)
use constructors instead of `move`
@dlang-bot
Copy link
Contributor

Thanks for your pull request, @MartinNowak!

Bugzilla references

Auto-close Bugzilla Severity Description
18657 normal std.range and std.algorithm can't handle refRange
18818 regression VariantN has unittests that are compiled into user modules
19765 normal std.algorithm.searching.findAmong doesn't save like it should

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + phobos#6943"

@wilzbach
Copy link
Member

wilzbach commented Apr 9, 2019

Looks like the RefRange changes make relativePath no longer save:

std/path.d(359): Error: `@safe` function `std.path.__unittest_L353_C7` cannot call `@system` function `std.path.relativePath!cast(CaseSensitive)false.relativePath`
std/path.d(2886):        `std.path.relativePath!cast(CaseSensitive)false.relativePath` is declared here

@aG0aep6G
Copy link
Contributor

aG0aep6G commented Apr 9, 2019

Looks like the RefRange changes make relativePath no longer save:

std/path.d(359): Error: `@safe` function `std.path.__unittest_L353_C7` cannot call `@system` function `std.path.relativePath!cast(CaseSensitive)false.relativePath`
std/path.d(2886):        `std.path.relativePath!cast(CaseSensitive)false.relativePath` is declared here

I've looked into this. PR: #6950

@wilzbach
Copy link
Member

wilzbach commented Apr 9, 2019

Closing in favor of #6951

@wilzbach wilzbach closed this Apr 9, 2019
@MartinNowak MartinNowak deleted the merge_stable branch April 20, 2019 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
6 participants