Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Issue 13965 - More handy schwartzSort #6999

Merged
merged 2 commits into from May 17, 2019

Conversation

AurelC2G
Copy link
Contributor

The goal is to be able to specify a SwapStrategy without also explicitly specifying the predicate to sort by (see example in the ticket, changelog, or the test I added).

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @AurelC2G! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
13965 enhancement More handy schwartzSort

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + phobos#6999"

Copy link
Member

@wilzbach wilzbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More tests to ensure this doesn't break in the future, but looks good otherwise 👍

Thanks!

std/algorithm/sorting.d Show resolved Hide resolved
@thewilsonator thewilsonator added the 72h no objection -> merge The PR will be merged if there are no objections raised. label May 12, 2019
@thewilsonator
Copy link
Contributor

Someone else feel free to merge earlier.

@thewilsonator thewilsonator added auto-merge and removed 72h no objection -> merge The PR will be merged if there are no objections raised. labels May 17, 2019
@dlang-bot dlang-bot merged commit cba72d9 into dlang:master May 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants