Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 20097 #7122

Merged
merged 1 commit into from
Aug 4, 2019
Merged

Fix issue 20097 #7122

merged 1 commit into from
Aug 4, 2019

Conversation

tchaloupka
Copy link
Contributor

Allow SysTime to be sendable with std.concurrency.send

Allow SysTime to be sendable with std.concurrency.send
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @tchaloupka! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
20097 normal SysTime cannot be used with std.concurrency.send

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + phobos#7122"

Copy link
Member

@Geod24 Geod24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great if the title of your commit (and PR) included the title of the issue you're fixing.
When one looks at notifications, or use git log, they have no clue what "issue 20097" is, but the title allow to quickly get an idea without opening every single PR / git showing every commit.

Otherwise, LGTM.

@dlang-bot dlang-bot merged commit 225a6af into dlang:master Aug 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants