llroundl is available on windows, so why not use it?

[John-Colvin]

I suspect this PR will fall foul of some platforms/runtimes... let's see :)

[dlang-bot]

Thanks for your pull request and interest in making D better, @John-Colvin! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

• My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
• My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
• I have provided a detailed rationale explaining my changes
• New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.

---

If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + phobos#7157"

[ghost]

Windows has no 80-bit floating point type. Long double in C is just double. That's probably why it wasn't implemented. Don't know why there's only a "real" overload in D either though...

[John-Colvin]

So... Windows 32 has llroundl declared but not actually present in the C runtime by the looks of things.

Is the autotester Win_32 working with DigitalMars or Microsoft C runtime?

[thewilsonator]

Digital Mars.

[John-Colvin]

What system tests with the 32 bit Microsoft runtime?

…

On Wed, 28 Aug 2019, 09:42 Nicholas Wilson, ***@***.***> wrote: Digital Mars. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#7157?email_source=notifications&email_token=AAOH3NK663UD2NCTN6U4XTDQGY26XA5CNFSM4IQHPGP2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5KLI7Y#issuecomment-525644927>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAOH3NJAA4TC7UCKDFYYTMLQGY26XANCNFSM4IQHPGPQ> .

[PetarKirov]

What system tests with the 32 bit Microsoft runtime?

Look for the Win_32_64 rows on the auto-tester.

It looks phobos is not independently tested with -m32mscoff.

[PetarKirov]

If you want to test with -m32mscoff, the best would be to setup Azure Pipelines, similarly to how it's done for dmd:

• https://github.com/dlang/dmd/blob/master/azure-pipelines.yml
• https://github.com/dlang/dmd/blob/f5069353042e50ea566f8ed28f6eb5d19a78cc9b/.azure-pipelines/windows.sh#L67

[RazvanN7]

std/math.d no longer exists; it has been refactored into multiple files. Right now the functions touched by this PR no longer call core.stdc.math.llroundl only for Posix. It has been refactored to assert if version=CRuntime_DigitalMars, which is correct.

Closing this.