Fix Issue 20147 - Enable comparison (==, >, >=, <=, <) between std.bigint.BigInt and floating point numbers #7172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request, @n8sh! Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + phobos#7172" |
n8sh
force-pushed
the
issue-20147
branch
3 times, most recently
from
ba77195
to
ebf7fad
Compare
thewilsonator
approved these changes
Sep 6, 2019
n8sh
force-pushed
the
issue-20147
branch
6 times, most recently
from
9a01dc9
to
e303902
Compare
…gint.BigInt and floating point numbers
n8sh
force-pushed
the
issue-20147
branch
2 times, most recently
from
3d56086
to
ce3e7f6
Compare
|
Good to go? |
|
Yep |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split off as its own PR separate from #7151 because there is a single mathematically correct way to compare numbers without needing to consider rounding mode.