Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

std.zip: Replace magic constants by constants named after specs #7201

Merged
merged 1 commit into from Oct 5, 2019
Merged

std.zip: Replace magic constants by constants named after specs #7201

merged 1 commit into from Oct 5, 2019

Conversation

ghost
Copy link

@ghost ghost commented Sep 27, 2019

This PR removes three public items: digiSignLength, eocd64LocLength and eocd64Length. They are replaced by private enums with names taken directly from the specs, making all names consistent.

Theoretically they should go through a deprecation process. But it's hard to imagine a usecase, where someone used these constants outside of std.zip. In my oppinion they should have been private from the very beginning.

@ghost ghost requested a review from CyberShadow as a code owner September 27, 2019 12:32
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @crocopaw! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + phobos#7201"

std/zip.d Outdated Show resolved Hide resolved
std/zip.d Show resolved Hide resolved
std/zip.d Outdated Show resolved Hide resolved
@dlang-bot dlang-bot merged commit bfc34bc into dlang:master Oct 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants