Fix Issue 15230 - Inconsistent std.range.SortedRange predicate checks

[ghost]

This may reopen issue 12661. I checked this and I think it does not reopen. But IMHO someone else should confirm this.

Anyway, I think, the original fix for 12661 did not fix the real problem, but was more of a hack inducing issue 15230.

[dlang-bot]

Thanks for your pull request and interest in making D better, @crocopaw! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

• My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
• My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
• I have provided a detailed rationale explaining my changes
• New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.

---

If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close	Bugzilla	Severity	Description
✓	15230	normal	Inconsistent std.range.SortedRange predicate checks

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + phobos#7205"

[ghost]

I'd like to add the WIP label, but could not find out, how to do so... Maybe I've got not the rights to do so...

[ghost]

While thinking about this issue I had to make up my mind about debug statements inside phobos. In my oppinion they should not appear (aside from code used for debugging phobos itself). It's a feature, that should be available for users to use to debug their own code. If the behaviour of phobos depends on being compiled with or without -debug, debugging usercode is complicated unnecessary. This may also lead to people not using pure, because "debug writeln(...)" and "writeln(...)" might lead to different results.

[thewilsonator]

Is this still WIP?

[ghost]

No. :-)