Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more unittests for CustomFloat. #7218

Merged
merged 1 commit into from Oct 17, 2019
Merged

Add more unittests for CustomFloat. #7218

merged 1 commit into from Oct 17, 2019

Conversation

ghost
Copy link

@ghost ghost commented Oct 9, 2019

Before going to fix issues #20261, #20263, #20281, #20282, #20283, #20284 and #20286 I want to make sure, that I don't break the stuff, that's allready working.

Corrected some small style mistakes too.

@ghost ghost requested a review from andralex as a code owner October 9, 2019 09:41
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @berni44! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + phobos#7218"

@atilaneves
Copy link
Contributor

Can any of those asserts be static asserts instead?

@ghost
Copy link
Author

ghost commented Oct 9, 2019

Can any of those asserts be static asserts instead?

Yes, I changed them.

@dlang-bot dlang-bot merged commit 391b789 into dlang:master Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants