Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add closures to warning and mark warning in red. #7268

Merged
merged 1 commit into from Dec 2, 2019
Merged

Add closures to warning and mark warning in red. #7268

merged 1 commit into from Dec 2, 2019

Conversation

ghost
Copy link

@ghost ghost commented Nov 12, 2019

This addresses issue 9603. I think, inside of Phobos this cannot be repaired (maybe with a complete rewrite), nor is it possible to add an exception to prevent the crash.

I remember, that I've seen an even more impressive warning somewhere, but could not find it again. I think it would be the right thing to add here.

@ghost ghost requested a review from andralex as a code owner November 12, 2019 12:49
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @berni44! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + phobos#7268"

@ghost
Copy link
Author

ghost commented Dec 2, 2019

ping

@PetarKirov
Copy link
Member

Thanks for the reminder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants