Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue 18248 - radix overload of std.conv.parse fails to throw on #7310

Merged
merged 1 commit into from Dec 10, 2019
Merged

Fix Issue 18248 - radix overload of std.conv.parse fails to throw on #7310

merged 1 commit into from Dec 10, 2019

Conversation

ghost
Copy link

@ghost ghost commented Dec 8, 2019

non-empty range without number

@ghost ghost requested a review from JackStouffer as a code owner December 8, 2019 13:17
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @berni44! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
18248 normal radix overload of std.conv.parse fails to throw on non-empty range without number

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + phobos#7310"

@dlang-bot dlang-bot merged commit 50205eb into dlang:master Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants