Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue 20160 - ThreadInfo.cleanup() clears local thread's... #7314

Merged
merged 1 commit into from Dec 11, 2019
Merged

Fix Issue 20160 - ThreadInfo.cleanup() clears local thread's... #7314

merged 1 commit into from Dec 11, 2019

Conversation

ghost
Copy link

@ghost ghost commented Dec 11, 2019

This is a copy of PR #7152. For what ever reason the original author insisted on not adding a unittest (which exists in bugzilla) and finally closed that issue.

@ghost ghost requested a review from MartinNowak as a code owner December 11, 2019 13:37
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @berni44! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
20160 normal ThreadInfo.cleanup() clears local thread's registered names instead of "this"'s

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + phobos#7314"

@ghost
Copy link
Author

ghost commented Dec 11, 2019

Errorlog from buildkite/phobos:

dmd: /var/lib/buildkite-agent/builds/ci-agent-75519bae-71c7-4594-b0ef-8e01a27fe867-3/dlang/phobos/dmd/src/dmd/backend/cgcod.d:2491: Assertion `cast(int)(*e).Ecomsub <= cast(int)(*e).Ecount' failed.

I don't know if this is triggered by this PR or something else...

@thewilsonator
Copy link
Contributor

That shows up on other PRs, so no.

@thewilsonator thewilsonator merged commit b7d6313 into dlang:master Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants