Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue 7446 - [TDPL] Trivial asynchronous file copy example crashes #7333

Merged
merged 1 commit into from Jan 2, 2020
Merged

Fix Issue 7446 - [TDPL] Trivial asynchronous file copy example crashes #7333

merged 1 commit into from Jan 2, 2020

Conversation

ghost
Copy link

@ghost ghost commented Dec 27, 2019

The original issue (docs telling, that the runtime catches the exception) seems not to exist anymore, but anyway, the functions should document, that they might throw. i also cleaned up the docs of the three functions a little bit.

@ghost ghost requested a review from MartinNowak as a code owner December 27, 2019 10:37
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @berni44! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
7446 normal [TDPL] Trivial asynchronous file copy example crashes with OwnerTerminated

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + phobos#7333"

@atilaneves
Copy link
Contributor

The "docs" in issue 7446 is TDPL, meaning that someone who read the book would get behaviour different from described there.

@ghost
Copy link
Author

ghost commented Dec 27, 2019

The "docs" in issue 7446 is TDPL, meaning that someone who read the book would get behaviour different from described there.

Ah, I thought TDPL was just an old way to reference the D docs.

The changes i suggest (including closing the issue) make sense anyway, don't they?

@atilaneves atilaneves added the 72h no objection -> merge The PR will be merged if there are no objections raised. label Dec 28, 2019
@ghost
Copy link
Author

ghost commented Jan 2, 2020

ping?

@thewilsonator thewilsonator added auto-merge and removed 72h no objection -> merge The PR will be merged if there are no objections raised. labels Jan 2, 2020
@dlang-bot dlang-bot merged commit d0d0259 into dlang:master Jan 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants