Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue 20743 - Checked!(int, Abort) does not abort but raise SIGFPE #7454

Merged
merged 1 commit into from Apr 23, 2020

Conversation

wolframw
Copy link
Contributor

The necessity for this is due to an x86 design idiosyncrasy. If an integer division causes an overflow, a division error occurs, causing SIGFPE to be raised on POSIX systems and the SEH exception EXCEPTION_INT_OVERFLOW to be thrown on Windows. Since the Warn hook performs the offending calculation nevertheless, a special case is added such that an overflowing division is not performed.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @wolframw! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
20743 normal Checked!(int, Abort) does not abort but raise SIGFPE

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#7454"

@dlang-bot dlang-bot merged commit 9844c34 into dlang:master Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants