Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 20929 - std.experimental.allocator.expandArray's range-based overload fails to instantiate for char and wchar arrays. #7530

Merged
merged 1 commit into from Jun 19, 2020

Conversation

just-harry
Copy link
Contributor

https://issues.dlang.org/show_bug.cgi?id=20929

The instantiation failure was caused by trying to get the address of an lvalue
for emplace, which was caused by front's auto-decoding of the slice used to
refer to the uninitialised elements of the array.

The fix was to forgo the range functions for the slice, and just index it.

The changes to ForcedInputRange may seem unrelated to the fix, but I wanted
to test the input-range code-path, and the only usage of ForcedInputRange
was to test this overload of expandArray, so it seemed more appropriate to
reuse it, rather than define another input-range.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @just-harry! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
20929 minor std.experimental.allocator.expandArray's range-based overload fails to instantiate for char and wchar arrays.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#7530"

std/experimental/allocator/package.d Show resolved Hide resolved
std/experimental/allocator/package.d Outdated Show resolved Hide resolved
std.experimental.allocator.expandArray's range-based overload fails to
instantiate for char and wchar arrays.
@andralex andralex merged commit a3dd382 into dlang:master Jun 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants