Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

std.meta: Fix wrong assert for Issue #20863 #7542

Merged
merged 1 commit into from Jul 8, 2020
Merged

std.meta: Fix wrong assert for Issue #20863 #7542

merged 1 commit into from Jul 8, 2020

Conversation

ntrel
Copy link
Contributor

@ntrel ntrel commented Jun 25, 2020 •
edited

Depends on dlang/dmd#11320 being merged first

This is needed for dlang/dmd#11320.

@ntrel ntrel mentioned this pull request Jun 25, 2020
Open
@MoonlightSentinel
Copy link
Contributor

Allthough a bit tedious, let's split this into multiple steps:

  1. Disable the assert in this PR
  2. Finish the dmd PR
  3. Enable the fixed assert in another PR.

@ntrel ntrel marked this pull request as ready for review July 7, 2020 13:24
@ntrel ntrel requested a review from MetaLang as a code owner July 7, 2020 13:24
@ntrel
Copy link
Contributor Author

ntrel commented Jul 8, 2020

Disable the assert in this PR

@MoonlightSentinel merge please ;-)

@MoonlightSentinel
Copy link
Contributor

MoonlightSentinel commented Jul 8, 2020 •
edited

Got no power here, @thewilsonator ?

EDIT: Restarted the failed BuildKite job

@thewilsonator thewilsonator merged commit a882717 into dlang:master Jul 8, 2020
@ntrel ntrel deleted the meta-qual branch July 8, 2020 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thewilsonator thewilsonator thewilsonator approved these changes

@MetaLang MetaLang Awaiting requested review from MetaLang MetaLang is a code owner

Assignees
No one assigned
Labels
auto-merge
Projects
None yet
Milestone
No milestone
3 participants
@ntrel @MoonlightSentinel @thewilsonator