std.bigint.BigInt: special case x & non-negative int to avoid unnecessary allocation #7544
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
x & 1
is a natural way to check the low bit ofstd.bigint.BigInt x
but that allocates unlike the less naturalx.getDigit!uint(0) & 1
. Examples of this appearing in Phobos arestd.bigint.powmod(BigInt, BigInt, BigInt)
(PR #7525 fixes it) andstd.numeric.gcd!T(T, T)
when instantiated forBigInt
. Adding special handling forx & 1
will aside from helping naive uses also improve performance of generic templated code that operates on arbitrary number-like types.