Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LDC] move pragma(inline, true); out of function bodies #7667

Merged
merged 1 commit into from Oct 19, 2020

Conversation

thewilsonator
Copy link
Contributor

cc @kinke

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @thewilsonator! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#7667"

@Geod24
Copy link
Member

Geod24 commented Oct 19, 2020

Can you expand on the rationale ?

@thewilsonator
Copy link
Contributor Author

see #7463 (comment) and #7463 (comment)

@Geod24
Copy link
Member

Geod24 commented Oct 19, 2020

Thanks. A mention in the commit message would have been great, too, so people can get this information offline / without having to go through 2 indirections :)

std/math.d Show resolved Hide resolved
Copy link
Member

@Geod24 Geod24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a minor formatting comment. Feel free to self-merge once fixed.

@Geod24
Copy link
Member

Geod24 commented Oct 19, 2020

@WalterBright : The LDC developers raise an important point. To allow for cross-module inlining, pragma(inline) should be outside of the function body, otherwise the compiler will have to analyze body of functions for non-root modules.
Should we consider deprecating usage of pragma(inline) inside of function body, and restrict it to be on the function's prototype ?

@dlang-bot dlang-bot merged commit bff8c21 into dlang:master Oct 19, 2020
@thewilsonator thewilsonator deleted the ldc-pragminline branch July 15, 2022 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants