Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue 21707 - std.base64: Faulty input creates range error instead of Base64Exception #7871

Merged
merged 1 commit into from Mar 16, 2021

Conversation

berni44
Copy link
Contributor

@berni44 berni44 commented Mar 16, 2021

Removed a misleading sentence from the documentation too (my last attempt to fix this, was guided by this sentence...)

Probably this fix is also needed for the unpadded version, but I don't know this exactly yet and don't want to break there anything...

@berni44 berni44 requested a review from andralex as a code owner March 16, 2021 17:21
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @berni44! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
21707 normal std.base64: Faulty input creates range error instead of Base64Exception

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#7871"

@dlang-bot dlang-bot merged commit 1ea7852 into dlang:master Mar 16, 2021
@berni44 berni44 deleted the issue_21707 branch April 28, 2021 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants