Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 21488 - Always compile phobos library with -fPIC on POSIX targets #8154

Merged
merged 1 commit into from Jul 2, 2021

Conversation

ibuclaw
Copy link
Member

@ibuclaw ibuclaw commented Jul 1, 2021

Segmentation faults or linker errors occur on 32-bit PIE platforms if any object is not compiled with -fPIC.

@dlang-bot
Copy link
Contributor

dlang-bot commented Jul 1, 2021

Thanks for your pull request, @ibuclaw!

Bugzilla references

Auto-close Bugzilla Severity Description
21488 normal Bundled 32-bit dlang tools (ddemangle, dustmite, rdmd) segfault on startup

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + phobos#8154"

@ibuclaw
Copy link
Member Author

ibuclaw commented Jul 1, 2021

Ping @MartinNowak don't know if you need to fix your release build scripts.

@thewilsonator thewilsonator merged commit 09c6e53 into dlang:stable Jul 2, 2021
@ibuclaw ibuclaw deleted the issue21488 branch July 2, 2021 07:26
@MartinNowak MartinNowak mentioned this pull request Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants