New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DSSv3] Fix Issue 13684 - std.numeric.isRectangular #8175
Conversation
Thanks for your pull request and interest in making D better, @lucica28! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + phobos#8175" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Retitle the commit message to say "Fix issue 13684 - add std.numeric.isRectangular"
@@ -1121,6 +1121,57 @@ T findRoot(T, DF)(scope DF f, const T a, const T b) | |||
return findRoot(f, a, b, (T a, T b) => false); | |||
} | |||
|
|||
bool isRectangular(T)(T arr) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs documentation
The commit message should contain the string "Fix Issue 13684 - ..." so that the bot picks it up. Upon merger, the bot will then automatically close the issue. |
I don't think Phobos needs such a function; it may encourage people to think jagged arrays (arrays of arrays) are a reasonable way to represent such rectangular multidimensional arrays, while we have a much better suited library for that: http://mir-algorithm.libmir.org/mir_ndslice.html Using |
Added new function isRectangular