New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DSSv3] Fix issue - 16339 #8181
Conversation
Thanks for your pull request and interest in making D better, @lucica28! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + phobos#8181" |
std/array.d
Outdated
@@ -1364,13 +1364,46 @@ if (isSomeString!(T[]) && allSatisfy!(isCharOrStringOrDcharRange, U)) | |||
} | |||
|
|||
/// | |||
@safe pure unittest | |||
@system unittest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before this addition, the unittest tested that the code is both @safe and pure. With this addition the first paragraph no longer tests that. Ideally, the added tests should be pure and @safe; if that is not possible, then just create a new unittest block that is @System. (from looking at the code, I don't see why purity is lost; also, the class example should be @safe)
14f61e7
to
2d72b54
Compare
[DSSv3] Fix issue - 16339 Signed-off-by: Razvan Nitu <RazvanN7@users.noreply.github.com> Merged-on-behalf-of: Razvan Nitu <RazvanN7@users.noreply.github.com>
[DSSv3] Fix issue - 16339 Signed-off-by: Razvan Nitu <RazvanN7@users.noreply.github.com> Merged-on-behalf-of: Razvan Nitu <RazvanN7@users.noreply.github.com>
[DSSv3] Fix issue - 16339 Signed-off-by: Razvan Nitu <RazvanN7@users.noreply.github.com> Merged-on-behalf-of: Razvan Nitu <RazvanN7@users.noreply.github.com>
std.array.insertInPlace: added tests for class and union.