Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression 16705 #8258

Merged
merged 2 commits into from
Oct 18, 2021
Merged

Fix regression 16705 #8258

merged 2 commits into from
Oct 18, 2021

Conversation

dukc
Copy link
Contributor

@dukc dukc commented Sep 30, 2021

No description provided.

@dukc dukc requested a review from andralex as a code owner September 30, 2021 15:28
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @dukc! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
16705 regression [REG2.069] TaskPool.reduce fails to compile "cannot get frame pointer to D main"

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + phobos#8258"

@thewilsonator
Copy link
Contributor

./travis-ci.sh
--
  | ./buildkite/build_project.sh: line 129: ./travis-ci.sh: No such file or directory

try rebasing this branch?

@dukc
Copy link
Contributor Author

dukc commented Oct 2, 2021

./travis-ci.sh
--
  | ./buildkite/build_project.sh: line 129: ./travis-ci.sh: No such file or directory

try rebasing this branch?

Huh, rebase what branch? Fix 16705 is already based on latest stable.

@RazvanN7
Copy link
Collaborator

I think that the base branch has been somehow messed up. Maybe opening a new PR on top of latest stable will fix this.

@dukc
Copy link
Contributor Author

dukc commented Oct 15, 2021

I think that the base branch has been somehow messed up. Maybe opening a new PR on top of latest stable will fix this.

Rebased on latest stable, and does not work. Will open a new pr - if it works I'll close this.

@dukc
Copy link
Contributor Author

dukc commented Oct 18, 2021

Another PR has changed the baseline DMD version, and CircleCI works again. Can someone turn auto-merge back on again one more time?

@dukc
Copy link
Contributor Author

dukc commented Oct 18, 2021

Quick reflexes! TY.

@dlang-bot dlang-bot merged commit 71087a1 into dlang:stable Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants