New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace FieldProxy with @property ref functions #8259
Conversation
Thanks for your pull request and interest in making D better, @pbackus! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + phobos#8259" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
LGTM. Unfortunately I can't guess why I didn't do it this way in 2011, ref properties did seem to be working at that point. |
0c029e2
to
e47f865
Compare
Oops, I forgot the function attributes the first time around (and the test suite didn't catch it—could use better coverage here). Should be good to go now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice
Auto-tester is failing on FreeBSD with this message:
The test in question is here: Lines 1639 to 1647 in 232ca53
I don't see how this test could possibly be affected by this PR, so I'm going to assume for now it's a flaky test and force-push to re-run. |
This simplifies the code and removes the need for a separate version (StdDdoc) block.
e47f865
to
ef1d49d
Compare
This simplifies the code and removes the need for a separate
version (StdDdoc) block.