OpenBSD: Add polyImpl implementation for x86

[ibara]

Fix Issue 22393 - OpenBSD: Add polyImpl implementation for x86

[dlang-bot]

Thanks for your pull request and interest in making D better, @ibara! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

• My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
• My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
• I have provided a detailed rationale explaining my changes
• New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.

---

If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close	Bugzilla	Severity	Description
✓	22393	enhancement	OpenBSD: Add polyImpl implementation for x86

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + phobos#8285"

[ibara]

Not sure what happened with circle-ci there. This shouldn't have the ability to break the build on any platform.

[dukc]

I believe the stable test is currently broken - not your fault. You can get around it by targetting master instead. Work like this usually goes to master anyway, stable is mainly for serious bugs.

[ibara]

I was somewhat hoping that build failure would be a serious bug 😄
But absolutely not a problem to target master.

[dukc]

It'd be a bug if it built or was thought to build before, but it seems you're fixing something that was simply not implemented - correct me if wrong.

[ibara]

Correct. I'm adding a should-have-been-implemented.

[kinke]

Stable is fine. - Could you please try bumping

phobos/.circleci/run.sh

Line 5 in b114d3f

HOST_DMD_VER=2.079.1

to 2.095.0 as for the DMD repo in https://github.com/dlang/dmd/blob/3dfa83b4a0375277c3052788d56c431f631492d9/.circleci/run.sh#L5? Seems like current DMD stable doesn't build with that old host compiler version anymore.

This is apparently the 5th identical asm block in that function. A follow-up introducing something like

version (linux) enum GenericPosixVersion = true;
else version(…) enum GenericPosixVersion = true;
else            enum GenericPosixVersion = false;
…
static if (GenericPosixVersion) …

would be nice.

[ibara]

This is apparently the 5th identical asm block in that function. A follow-up introducing something like

version (linux) enum GenericPosixVersion = true;
else version(…) enum GenericPosixVersion = true;
else            enum GenericPosixVersion = false;
…
static if (GenericPosixVersion) …

would be nice.

Sure. I'll send a follow-up once this goes in.

[ibuclaw]

Stable is fine. - Could you please try bumping

phobos/.circleci/run.sh

Line 5 in b114d3f

HOST_DMD_VER=2.079.1

to 2.095.0 as for the DMD repo in https://github.com/dlang/dmd/blob/3dfa83b4a0375277c3052788d56c431f631492d9/.circleci/run.sh#L5? Seems like current DMD stable doesn't build with that old host compiler version anymore.

This is apparently the 5th identical asm block in that function. A follow-up introducing something like

version (linux) enum GenericPosixVersion = true;
else version(…) enum GenericPosixVersion = true;
else            enum GenericPosixVersion = false;
…
static if (GenericPosixVersion) …

would be nice.

version GenericPosixVersion would be safer, or private enum.

[kinke]

version GenericPosixVersion would be safer, or private enum.

[I meant a function-local enum, not a global one.]

[ibuclaw]

You can set this up per environment IIRC.
2.095 is too new for the general case.

[dukc]

Thank you folks! Now I can get my own PR to stable merged.