Fix Issue 18051 - missing enum support in formattedRead/unformatValue #8345
Conversation
|
Thanks for your pull request and interest in making D better, @wolframw! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + phobos#8345" |
| text("Wrong unformat specifier '%", spec , "' for ", T.stringof)); | ||
|
|
||
| return parse!T(input); | ||
| } |
There was a problem hiding this comment.
While implementing this, I found that the unformatValue implementation for ordinary arrays and for associative arrays is identical and can be reused for enums too - that's why the diff shows a removed function.
std/format/read.d
Outdated
|
|
||
| Op op; | ||
| Op[] ops; | ||
| assert(formattedRead!"%s [%(%s, %)]"("lt [lt, gt, eq]", op, ops) == 2); |
There was a problem hiding this comment.
Why not the simpler test in the issue description instead?
There was a problem hiding this comment.
That's a leftover from when I wasn't sure if the same implementation works for arrays and enums (and arrays of enums). I'll change it to the simpler test case.
No description provided.