Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new __traits(classInstanceAlignment) #8459

Merged
merged 1 commit into from May 13, 2022
Merged

Use new __traits(classInstanceAlignment) #8459

merged 1 commit into from May 13, 2022

Conversation

kinke
Copy link
Contributor

@kinke kinke commented May 13, 2022

No description provided.

@dlang-bot
Copy link
Contributor

dlang-bot commented May 13, 2022

Thanks for your pull request and interest in making D better, @kinke! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
16508 normal Alignment of class members is not respected. Affects new, scoped and classInstanceAlignment.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#8459"

Tackling the Phobos part of issue 16508.
@dlang-bot dlang-bot merged commit b20444a into dlang:master May 13, 2022
@ljmf00
Copy link
Member

ljmf00 commented May 13, 2022

I didn't read the issue carefully before merging this and Stanislav Blinov mentioned there about creating separate issues for Phobos. Perhaps it is required to create separate issues for Phobos? Sorry for my lack of attention 😢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants